GHSA-HF8H-97GM-4X2P

Vulnerability from github – Published: 2026-10-01 15:46 – Updated: 2026-10-01 15:46
VLAI
Summary
SiYuan: getUniqueFilename passes an unvalidated client-supplied path to the filesystem, giving anonymous readers an existence oracle over the entire host filesystem
Details

Summary

/api/file/getUniqueFilename takes a path from the request body and passes it to a filesystem existence check with no validation, confinement or authorization. The response distinguishes paths that exist from paths that do not, so an anonymous reader in publish mode can probe arbitrary locations on the host, one request per probe. Files and directories both work.

Every neighbouring file route either requires an administrator or confines the path first.

Details

Route. kernel/api/router.go:289 on master, :292 on the development branch, CheckAuth only.

Handler, kernel/api/file.go:84, in full:

util.ParseJsonArgs(arg, ret, util.BindJsonArg("path", &filePath, true, true))
ret.Data = map[string]any{"path": util.GetUniqueFilename(filePath)}

The argument binder does no path handling. util.BindJsonArg (kernel/util/net.go:365) takes two booleans, required (the key must be present) and rejectEmpty (the value must be non-empty). That is its entire contract. There is no filepath.Clean, no workspace join, no traversal check. An absolute path outside the workspace reaches gulu.File.IsExist unmodified.

The oracle. util/file.go:67:

if !gulu.File.IsExist(filePath) {
    return filePath
}
// otherwise loop, returning the first non-existent dir/base (i).ext

Input echoed back means the path does not exist. A (1) suffix means it does.

The asymmetry.

Route Middleware
putFile, copyFile, globalCopyFiles, workspaceCopyFiles, removeFile, renameFile CheckAuth, CheckAdminRole, CheckReadonly
readDir (directory enumeration) CheckAuth, CheckAdminRole
getFile CheckAuth, but GetAbsPathInWorkspace returns 403 on escape, plus rejectEncryptedBoxPath and a publish-access check
getUniqueFilename CheckAuth, nothing else

getFile binds the identical BindJsonArg("path", &filePath, true, true) and confines it as its first action.

Proof of Concept

Kernel 3.7.2, publish mode on port 6808, Publish.Auth.Enable false, anonymous client. Reader context confirmed by getChildBlocks returning HTTP 403 on the same session.

{"path":"/etc/passwd"}
→ {"code":0,"msg":"","data":{"path":"/etc/passwd (1)"}}

{"path":"/etc/shadow"}
→ {"code":0,"msg":"","data":{"path":"/etc/shadow (1)"}}

{"path":"/etc/definitely-not-here"}
→ {"code":0,"msg":"","data":{"path":"/etc/definitely-not-here"}}

Directories behave the same way:

{"path":"/root"}      → {"path":"/root (1)"}
{"path":"/rootnope"}  → {"path":"/rootnope"}

And within the workspace, confirming whether a specific document file exists:

{"path":"<workspace>/data/<boxID>/<docID>.sy"}  → "<...> (1).sy"
{"path":"<workspace>/data/nope-no-such.sy"}     → echoed unchanged

Impact

An anonymous reader in publish mode, or any publish RoleReader, determines whether arbitrary paths exist on the host. Because directories respond the same way as files, the filesystem can be walked rather than only guessed at. This supports identifying the operating-system user's home directory, detecting installed software, backup and synchronisation directories, mapping the workspace layout, and confirming the existence of specific documents by probing their storage paths.

It also composes with the absolute workspace path returned elsewhere, which supplies a concrete prefix rather than requiring guesswork, and it recovers the operating-system username that the browser-request path strip added under issue #17410 was introduced to conceal.

Scoped precisely: nothing is read and nothing is written. This is an existence and layout disclosure, valuable primarily as a reconnaissance step.

Suggested fix

Confine the path as the adjacent getFile route does, by routing filePath through util.GetAbsPathInWorkspace and returning 403 on escape, or add CheckAdminRole and CheckReadonly to match readDir. The frontend uses this endpoint only for naming uploads and assets inside the workspace, so neither change affects legitimate use.

Show details on source website

{
  "affected": [
    {
      "package": {
        "ecosystem": "Go",
        "name": "github.com/siyuan-note/siyuan/kernel"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "0.0.0-20260812083335-251596fc0de2"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2026-73605"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-862"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2026-10-01T15:46:01Z",
    "nvd_published_at": null,
    "severity": "MODERATE"
  },
  "details": "### Summary\n\n`/api/file/getUniqueFilename` takes a path from the request body and passes it to a filesystem existence check with no validation, confinement or authorization. The response distinguishes paths that exist from paths that do not, so an anonymous reader in publish mode can probe arbitrary locations on the host, one request per probe. Files and directories both work.\n\nEvery neighbouring file route either requires an administrator or confines the path first.\n\n### Details\n\n**Route.** `kernel/api/router.go:289` on master, `:292` on the development branch, `CheckAuth` only.\n\n**Handler,** `kernel/api/file.go:84`, in full:\n\n```go\nutil.ParseJsonArgs(arg, ret, util.BindJsonArg(\"path\", \u0026filePath, true, true))\nret.Data = map[string]any{\"path\": util.GetUniqueFilename(filePath)}\n```\n\n**The argument binder does no path handling.** `util.BindJsonArg` (`kernel/util/net.go:365`) takes two booleans, `required` (the key must be present) and `rejectEmpty` (the value must be non-empty). That is its entire contract. There is no `filepath.Clean`, no workspace join, no traversal check. An absolute path outside the workspace reaches `gulu.File.IsExist` unmodified.\n\n**The oracle.** `util/file.go:67`:\n\n```go\nif !gulu.File.IsExist(filePath) {\n    return filePath\n}\n// otherwise loop, returning the first non-existent dir/base (i).ext\n```\n\nInput echoed back means the path does not exist. A `(1)` suffix means it does.\n\n**The asymmetry.**\n\n| Route | Middleware |\n|---|---|\n| `putFile`, `copyFile`, `globalCopyFiles`, `workspaceCopyFiles`, `removeFile`, `renameFile` | `CheckAuth`, `CheckAdminRole`, `CheckReadonly` |\n| `readDir` (directory enumeration) | `CheckAuth`, `CheckAdminRole` |\n| `getFile` | `CheckAuth`, but `GetAbsPathInWorkspace` returns 403 on escape, plus `rejectEncryptedBoxPath` and a publish-access check |\n| `getUniqueFilename` | `CheckAuth`, nothing else |\n\n`getFile` binds the identical `BindJsonArg(\"path\", \u0026filePath, true, true)` and confines it as its first action.\n\n### Proof of Concept\n\nKernel 3.7.2, publish mode on port 6808, `Publish.Auth.Enable` false, anonymous client. Reader context confirmed by `getChildBlocks` returning HTTP 403 on the same session.\n\n```\n{\"path\":\"/etc/passwd\"}\n\u2192 {\"code\":0,\"msg\":\"\",\"data\":{\"path\":\"/etc/passwd (1)\"}}\n\n{\"path\":\"/etc/shadow\"}\n\u2192 {\"code\":0,\"msg\":\"\",\"data\":{\"path\":\"/etc/shadow (1)\"}}\n\n{\"path\":\"/etc/definitely-not-here\"}\n\u2192 {\"code\":0,\"msg\":\"\",\"data\":{\"path\":\"/etc/definitely-not-here\"}}\n```\n\nDirectories behave the same way:\n\n```\n{\"path\":\"/root\"}      \u2192 {\"path\":\"/root (1)\"}\n{\"path\":\"/rootnope\"}  \u2192 {\"path\":\"/rootnope\"}\n```\n\nAnd within the workspace, confirming whether a specific document file exists:\n\n```\n{\"path\":\"\u003cworkspace\u003e/data/\u003cboxID\u003e/\u003cdocID\u003e.sy\"}  \u2192 \"\u003c...\u003e (1).sy\"\n{\"path\":\"\u003cworkspace\u003e/data/nope-no-such.sy\"}     \u2192 echoed unchanged\n```\n\n### Impact\n\nAn anonymous reader in publish mode, or any publish `RoleReader`, determines whether arbitrary paths exist on the host. Because directories respond the same way as files, the filesystem can be walked rather than only guessed at. This supports identifying the operating-system user\u0027s home directory, detecting installed software, backup and synchronisation directories, mapping the workspace layout, and confirming the existence of specific documents by probing their storage paths.\n\nIt also composes with the absolute workspace path returned elsewhere, which supplies a concrete prefix rather than requiring guesswork, and it recovers the operating-system username that the browser-request path strip added under issue #17410 was introduced to conceal.\n\nScoped precisely: nothing is read and nothing is written. This is an existence and layout disclosure, valuable primarily as a reconnaissance step.\n\n### Suggested fix\n\nConfine the path as the adjacent `getFile` route does, by routing `filePath` through `util.GetAbsPathInWorkspace` and returning 403 on escape, or add `CheckAdminRole` and `CheckReadonly` to match `readDir`. The frontend uses this endpoint only for naming uploads and assets inside the workspace, so neither change affects legitimate use.",
  "id": "GHSA-hf8h-97gm-4x2p",
  "modified": "2026-10-01T15:46:01Z",
  "published": "2026-10-01T15:46:01Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/siyuan-note/siyuan/security/advisories/GHSA-hf8h-97gm-4x2p"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2026-73605"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/siyuan-note/siyuan"
    },
    {
      "type": "WEB",
      "url": "https://www.vulncheck.com/advisories/siyuan-before-path-traversal-via-getuniquefilename"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:L/I:N/A:N",
      "type": "CVSS_V3"
    }
  ],
  "summary": "SiYuan: getUniqueFilename passes an unvalidated client-supplied path to the filesystem, giving anonymous readers an existence oracle over the entire host filesystem"
}



Log in or create an account to share your comment.




Tags
Taxonomy of the tags.


Loading…

Loading…

Loading…

Drag nodes to arrange them. Double-click a related vulnerability to open it, or a source to visit its link. The Physics button on the left tunes the layout and the simulation; the legend at the bottom left hides or shows nodes by kind and by sighting type.

Forecast uses a logistic model when the trend is rising, or an exponential decay model when the trend is falling. Fitted via linearized least squares.

Sightings

Author Source Type Date Other

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.
Vulnerability timeline

Sightings and recorded dates, grouped by day · UTC

JSON
How durations are calculated

Following the VTEM framework (Black Hat USA 2015), time to patch starts when the vendor or a coordinator was informed, total time to patch at discovery, and disclosure to patch at public disclosure; vendor response time runs from the report to its acknowledgement. Time to exploit and time unpatched start at the earliest discovery or report, falling back to public disclosure. Unpatched time ends at the first recorded patch, or the calculation time when no patch is recorded. Exploitation to patch shows the interval between those two events; a published proof of concept is a public exploit, not exploitation.

Each result shows its source dates. A negative interval means the end event came first; when date-only inputs leave the order open, the result says so. Date-only inputs are approximate. The earliest evidence wins: KEV report dates and sightings are labelled as such. Records describing another vulnerability are listed but never calculated from, and a PoC alone does not establish exploitation. Missing patch evidence does not prove that no patch exists. Filters below change the event list only.

Events included in the timeline

Loading timeline…


    Loading…

    Loading…

    Loading…

    Related by attack behaviour

    Vulnerabilities whose description is nearest to this one in the vector space of the CIRCL/vulnerability-attack-technique-biencoder model. This is a similarity search over the bi-encoder space (plain cosine), not a classification, and it has no measured accuracy.