GHSA-QMV4-JGP7-MF68

Vulnerability from github – Published: 2019-02-18 23:40 – Updated: 2022-08-03 21:27
VLAI?
Summary
Sails before 0.12.7 vulnerable to Broken CORS
Details

Affected versions of sails have an issue with the CORS configuration where the value of the origin header is reflected as the value for the Access-Control-Allow-Origin header. This may allow an attacker to make AJAX requests to vulnerable hosts through cross-site scripting or a malicious HTML Document, effectively bypassing the Same Origin Policy.

Mitigating Factors

This is only an issue when allRoutes is set to true and origin is set to * or left commented out in the sails CORS config file.

The problem can be compounded when the cors credentials setting is not provided, because at that point authenticated cross domain requests are possible.

Recommendation

Update to version 0.12.7 or later.

As this vulnerability is primarily a user error, the patch for the vulnerability will simply cause the application to write an error message to the console when a vulnerable configuration is used in a production environment.

Writing a proper CORS configuration is still the responsibility of the user, so it is necessary to check for the error message after installing the patch. Be sure you are not using allRoutes: true with origin:'*', and that you uncomment origin and set it to a reasonable value. Ensure that if origin is set to * that you truly mean for all other websites to be able to make cross-domain requests to your API.

Likewise, ensure credentials is uncommented out and set to the appropriate value. Make sure to explicitly set which origins may request resources via CORS.

Show details on source website
To clipboard 

{
  "affected": [
    {
      "package": {
        "ecosystem": "npm",
        "name": "sails"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "0.12.7"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2016-10549"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-284"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2020-06-16T21:52:24Z",
    "nvd_published_at": null,
    "severity": "HIGH"
  },
  "details": "Affected versions of `sails` have an issue with the CORS configuration where the value of the origin header is reflected as the value for the `Access-Control-Allow-Origin` header. This may allow an attacker to make AJAX requests to vulnerable hosts through cross-site scripting or a malicious HTML Document, effectively bypassing the Same Origin Policy. \n\n## Mitigating Factors\n\nThis is only an issue when `allRoutes` is set to `true` and `origin` is set to `*` or left commented out in the sails CORS config file. \n\nThe problem can be compounded when the cors `credentials` setting is not provided, because at that point authenticated cross domain requests are possible.\n\n\n## Recommendation\n\nUpdate to version 0.12.7 or later.\n\nAs this vulnerability is primarily a user error, the patch for the vulnerability will simply cause the application to write an error message to the console when a vulnerable configuration is used in a production environment.\n\nWriting a proper CORS configuration is still the responsibility of the user, so it is necessary to check for the error message after installing the patch. Be sure you are not using `allRoutes: true` with `origin:\u0027*\u0027`, and that you uncomment `origin` and set it to a reasonable value. Ensure that if `origin` is set to `*` that you truly mean for all other websites to be able to make cross-domain requests to your API.\n\nLikewise, ensure `credentials` is uncommented out and set to the appropriate value. Make sure to explicitly set which origins may request resources via CORS.",
  "id": "GHSA-qmv4-jgp7-mf68",
  "modified": "2022-08-03T21:27:52Z",
  "published": "2019-02-18T23:40:10Z",
  "references": [
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2016-10549"
    },
    {
      "type": "WEB",
      "url": "https://github.com/balderdashy/sails/commit/0057123a0321be6758845abbeb4290bf418ce542"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/balderdashy/sails"
    },
    {
      "type": "WEB",
      "url": "https://github.com/balderdashy/sails/releases/tag/v0.12.7"
    },
    {
      "type": "WEB",
      "url": "https://www.npmjs.com/advisories/148"
    },
    {
      "type": "WEB",
      "url": "http://sailsjs.org/documentation/concepts/security/cors"
    },
    {
      "type": "WEB",
      "url": "http://sailsjs.org/documentation/reference/configuration/sails-config-cors"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [],
  "summary": "Sails before 0.12.7 vulnerable to Broken CORS"
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.



Detection rules are retrieved from Rulezet.