GHSA-MP76-7W5V-PR75
Vulnerability from github – Published: 2024-03-15 19:53 – Updated: 2024-03-18 16:48Impact
TurboBoost Commands has existing protections in place to guarantee that only public methods on Command classes can be invoked; however, the existing checks aren't as robust as they should be. It's possible for a sophisticated attacker to invoke more methods than should be permitted depending on the the strictness of authorization checks that individual applications enforce. Being able to call some of these methods can have security implications.
Details
Commands verify that the class must be a Command and that the method requested is defined as a public method; however, this isn't robust enough to guard against all unwanted code execution. The library should more strictly enforce which methods are considered safe before allowing them to be executed.
Patches
Patched in the following versions. - 0.1.3 - NPM Package - Ruby GEM - 0.2.2 - NPM Package - Ruby GEM
Workarounds
You can add this guard to mitigate the issue if running an unpatched version of the library.
class ApplicationCommand < TurboBoost::Commands::Command
before_command do
method_name = params[:name].include?("#") ? params[:name].split("#").last : :perform
ancestors = self.class.ancestors[0..self.class.ancestors.index(TurboBoost::Commands::Command) - 1]
allowed = ancestors.any? { |a| a.public_instance_methods(false).any? method_name.to_sym }
throw :abort unless allowed # ← blocks invocation
# raise "Invalid Command" unless allowed # ← blocks invocation
end
end
{
"affected": [
{
"package": {
"ecosystem": "RubyGems",
"name": "turbo_boost-commands"
},
"ranges": [
{
"events": [
{
"introduced": "0"
},
{
"fixed": "0.1.3"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "RubyGems",
"name": "turbo_boost-commands"
},
"ranges": [
{
"events": [
{
"introduced": "0.2.0"
},
{
"fixed": "0.2.2"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "@turbo-boost/commands"
},
"ranges": [
{
"events": [
{
"introduced": "0"
},
{
"fixed": "0.1.3"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "@turbo-boost/commands"
},
"ranges": [
{
"events": [
{
"introduced": "0.2.0"
},
{
"fixed": "0.2.2"
}
],
"type": "ECOSYSTEM"
}
]
}
],
"aliases": [
"CVE-2024-28181"
],
"database_specific": {
"cwe_ids": [
"CWE-74"
],
"github_reviewed": true,
"github_reviewed_at": "2024-03-15T19:53:50Z",
"nvd_published_at": "2024-03-14T18:15:07Z",
"severity": "HIGH"
},
"details": "### Impact\nTurboBoost Commands has existing protections in place to guarantee that only public methods on Command classes can be invoked; however, the existing checks aren\u0027t as robust as they should be. It\u0027s possible for a sophisticated attacker to invoke more methods than should be permitted depending on the the strictness of authorization checks that individual applications enforce. Being able to call some of these methods can have security implications.\n\n#### Details\nCommands verify that the class must be a `Command` and that the method requested is defined as a public method; however, this isn\u0027t robust enough to guard against all unwanted code execution. The library should more strictly enforce which methods are considered safe before allowing them to be executed. \n\n### Patches\nPatched in the following versions.\n- 0.1.3\n - [NPM Package](https://www.npmjs.com/package/@turbo-boost/commands/v/0.1.3)\n - [Ruby GEM](https://rubygems.org/gems/turbo_boost-commands/versions/0.1.3)\n- 0.2.2\n - [NPM Package](https://www.npmjs.com/package/@turbo-boost/commands/v/0.2.2)\n - [Ruby GEM](https://rubygems.org/gems/turbo_boost-commands/versions/0.2.2)\n\n\n### Workarounds\nYou can add this guard to mitigate the issue if running an unpatched version of the library.\n\n```ruby\nclass ApplicationCommand \u003c TurboBoost::Commands::Command\n before_command do\n method_name = params[:name].include?(\"#\") ? params[:name].split(\"#\").last : :perform\n ancestors = self.class.ancestors[0..self.class.ancestors.index(TurboBoost::Commands::Command) - 1]\n allowed = ancestors.any? { |a| a.public_instance_methods(false).any? method_name.to_sym }\n throw :abort unless allowed # \u2190 blocks invocation\n # raise \"Invalid Command\" unless allowed # \u2190 blocks invocation\n end\nend\n```\n",
"id": "GHSA-mp76-7w5v-pr75",
"modified": "2024-03-18T16:48:24Z",
"published": "2024-03-15T19:53:50Z",
"references": [
{
"type": "WEB",
"url": "https://github.com/hopsoft/turbo_boost-commands/security/advisories/GHSA-mp76-7w5v-pr75"
},
{
"type": "ADVISORY",
"url": "https://nvd.nist.gov/vuln/detail/CVE-2024-28181"
},
{
"type": "WEB",
"url": "https://github.com/hopsoft/turbo_boost-commands/commit/337cda7d9222f1f449905454a7374222017a7477"
},
{
"type": "WEB",
"url": "https://github.com/hopsoft/turbo_boost-commands/commit/88af4fc0ac39cc1799d16c49fab52f6dfbcec9ba"
},
{
"type": "PACKAGE",
"url": "https://github.com/hopsoft/turbo_boost-commands"
},
{
"type": "WEB",
"url": "https://github.com/rubysec/ruby-advisory-db/blob/master/gems/turbo_boost-commands/CVE-2024-28181.yml"
}
],
"schema_version": "1.4.0",
"severity": [
{
"score": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H",
"type": "CVSS_V3"
}
],
"summary": "TurboBoost Commands vulnerable to arbitrary method invocation"
}
Sightings
| Author | Source | Type | Date |
|---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or observed by the user.
- Confirmed: The vulnerability has been validated from an analyst's perspective.
- Published Proof of Concept: A public proof of concept is available for this vulnerability.
- Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
- Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
- Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
- Not confirmed: The user expressed doubt about the validity of the vulnerability.
- Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.