GHSA-2Q59-H24C-W6FG

Vulnerability from github – Published: 2024-04-03 14:13 – Updated: 2024-04-04 13:37
VLAI?
Summary
Voilà Local file inclusion
Details

Impact

Any deployment of voilà dashboard allow local file inclusion, that is to say any file on a filesystem that is readable by the user that runs the voilà dashboard server can be downloaded by someone with network access to the server.

Whether this still requires authentication depends on how voilà is deployed.

Patches

This is patched in 0.2.17+, 0.3.8+, 0.4.4+, 0.5.6+

Workarounds

None.

References

CWE-73: External Control of File Name or Path

Original report

I have found a local file inclusion vulnerability in one of your subprojects, voila (https://github.com/voila-dashboards/voila).

The vulnerability exists in the "/static" Route, and can be exploited by simply making a request such as this:

$ curl localhost:8866/static/etc/passwd

...or by using a webbrowser to download the file.

I dug into the source code, and I think the offending line is here: https://github.com/voila-dashboards/voila/blob/8419cc7d79c0bb1dabfbd9ec49cb957740609d4d/voila/app.py#L664 "static_path" gets set to "/", irrespective of the actual "--static" cli option. Because of that, the tornado.web.StaticFileHandler gets initialized with path="/". Then, tornado.web.StaticFileHandler.get calls tornado.web.StaticFileHandler.get_absolute_path with root="/" and path="[USER SUPPLIED PATH]", which leads to local file inclusion. An attacker can request any file on the system they want (that the user running voila has access to).

I suspect this was an oversight during development. Setting static_path=self.static_root (the aforementioned correct cli option) in line 664 provides the intended behavior and restricts the file access to the static directory. From what I can tell, this line has been in the repository since September 2018. This is the commit that added it: https://github.com/voila-dashboards/voila/commit/28faacc9b03b160fd8fa920ad045f4ec0667ab67

I have found multiple voila instances online that are impacted, such as: - ... [redacted] - ... [redacted] - ... [redacted]

...but many more probably exist. They're easy to identify by [redacted] Therefore the Issue should be fixed as soon as possible, and a security advisory should be released to inform the impacted users.

Severity ?
7.5 (High)
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N
Show details on source website
To clipboard 

{
  "affected": [
    {
      "package": {
        "ecosystem": "PyPI",
        "name": "voila"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0.0.2"
            },
            {
              "fixed": "0.2.17"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    },
    {
      "package": {
        "ecosystem": "PyPI",
        "name": "voila"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0.3.0a0"
            },
            {
              "fixed": "0.3.8"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    },
    {
      "package": {
        "ecosystem": "PyPI",
        "name": "voila"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0.4.0a0"
            },
            {
              "fixed": "0.4.4"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    },
    {
      "package": {
        "ecosystem": "PyPI",
        "name": "voila"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0.5.0a0"
            },
            {
              "fixed": "0.5.6"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2024-30265"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-73"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2024-04-03T14:13:02Z",
    "nvd_published_at": "2024-04-03T23:15:13Z",
    "severity": "HIGH"
  },
  "details": "### Impact\n\nAny deployment of voil\u00e0 dashboard allow local file inclusion, that is to say any file on a filesystem that is readable by the user that runs the voil\u00e0 dashboard server can be downloaded by someone with network access to the server. \n\nWhether this still requires authentication depends on how voil\u00e0 is deployed.\n\n### Patches\n\nThis is patched in 0.2.17+, 0.3.8+, 0.4.4+, 0.5.6+\n\n### Workarounds\n\nNone.\n\n\n### References\n\nCWE-73: External Control of File Name or Path\n\n\n### Original report\n\nI have found a local file inclusion vulnerability in one of your subprojects, voila (https://github.com/voila-dashboards/voila).\n\nThe vulnerability exists in the \"/static\" Route, and can be exploited by simply making a request such as this:\n\n```\n$ curl localhost:8866/static/etc/passwd\n```\n\n...or by using a webbrowser to download the file.\n\nI dug into the source code, and I think the offending line is here: https://github.com/voila-dashboards/voila/blob/8419cc7d79c0bb1dabfbd9ec49cb957740609d4d/voila/app.py#L664\n`\"static_path\"` gets set to `\"/\"`, irrespective of the actual `\"--static\"` cli option. Because of that, the `tornado.web.StaticFileHandler` gets initialized with `path=\"/\"`. Then, `tornado.web.StaticFileHandler.get` calls `tornado.web.StaticFileHandler.get_absolute_path` with `root=\"/\"` and `path=\"[USER SUPPLIED PATH]\"`, which leads to local file inclusion. An attacker can request any file on the system they want (that the user running voila has access to).\n\nI suspect this was an oversight during development. Setting `static_path=self.static_root` (the aforementioned correct cli option) in line 664 provides the intended behavior and restricts the file access to the static directory.\nFrom what I can tell, this line has been in the repository since September 2018. This is the commit that added it: https://github.com/voila-dashboards/voila/commit/28faacc9b03b160fd8fa920ad045f4ec0667ab67\n\nI have found multiple voila instances online that are impacted, such as:\n- ... [redacted]\n- ... [redacted]\n- ... [redacted]\n\n...but many more probably exist. They\u0027re easy to identify by `[redacted]` Therefore the Issue should be fixed as soon as possible, and a security advisory should be released to inform the impacted users.\n\n",
  "id": "GHSA-2q59-h24c-w6fg",
  "modified": "2024-04-04T13:37:56Z",
  "published": "2024-04-03T14:13:02Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/voila-dashboards/voila/security/advisories/GHSA-2q59-h24c-w6fg"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-30265"
    },
    {
      "type": "WEB",
      "url": "https://github.com/voila-dashboards/voila/commit/00d6362c237b6b4d466873535554d6076ead0c52"
    },
    {
      "type": "WEB",
      "url": "https://github.com/voila-dashboards/voila/commit/28faacc9b03b160fd8fa920ad045f4ec0667ab67"
    },
    {
      "type": "WEB",
      "url": "https://github.com/voila-dashboards/voila/commit/5542e4ae36bb5d184deaa48f95e76be477756af2"
    },
    {
      "type": "WEB",
      "url": "https://github.com/voila-dashboards/voila/commit/98b6a40fec27723572314fdbba99bdc147d904c8"
    },
    {
      "type": "WEB",
      "url": "https://github.com/voila-dashboards/voila/commit/c045be6988539d07cceeb9f82fc660a49485d504"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/voila-dashboards/voila"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N",
      "type": "CVSS_V3"
    }
  ],
  "summary": "Voil\u00e0 Local file inclusion"
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.



Detection rules are retrieved from Rulezet.